That is a good question Andrew.

I edit most photos prior to importing them. I hardly ever edit digital photos. And most film scans just require me to clean them up a bit before I import them into the library.

If I do edit a photo it I usually to crop it or something for publishing it. For that I will right click on a photo in the Photos app, and reveal it in the finder. Then I will open Photoshop to edit it.